Trac 56975 Stub functions in noop and restore caching #3872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option 2: Stubbing the functions in
wp-admin/includes/noop.php
:As detailed in the trac ticket, this PR implements option 2 to prevent the fatal error due to
load-styles.php
only loading a very small subset of WordPress, thus not having thewp_cache_*()
functions available.This PR:
wp_cache_get()
andwp_cache_set()
returning their failure state.wp_theme_has_theme_json
: add public method to know whether the theme supportstheme.json
#3556 (reverted in r55092.How to test:
wp-config.php
:load-styles.php
as a CSS file.Trac ticket: https://core.trac.wordpress.org/ticket/56975
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.