Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _wp_array_set function #1263

Closed
wants to merge 2 commits into from
Closed

Add _wp_array_set function #1263

wants to merge 2 commits into from

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented May 18, 2021 •
edited
Loading

Part of https://core.trac.wordpress.org/ticket/53175

This pull request adds the _wp_array_get function, which is the counterpart of the existing _wp_array_set. This is to be used by #1262

@oandregal oandregal mentioned this pull request May 18, 2021
Closed
jorgefilipecosta
jorgefilipecosta reviewed May 21, 2021
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include the unit tests available at phpunit/class-gutenberg-utils-test.php?

@oandregal
Copy link
Member Author

@jorgefilipecosta pushed the unit tests.

@oandregal
Copy link
Member Author

Landed at c0084bc

@oandregal oandregal closed this May 24, 2021
@oandregal oandregal deleted the add/array-set branch May 24, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgefilipecosta jorgefilipecosta jorgefilipecosta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oandregal @jorgefilipecosta