Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/badges #1438

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Add/badges #1438

merged 12 commits into from
Dec 12, 2024

Conversation

pkevan
Copy link
Contributor

@pkevan pkevan commented Dec 10, 2024

Adds an admin interface into Camptix to allow administrators to assign badges to users.

Fixes #1428

@pkevan pkevan added the [Component] CampTix Including addons label Dec 10, 2024
@pkevan pkevan requested a review from renintw December 10, 2024 16:10
@pkevan
Copy link
Contributor Author

pkevan commented Dec 10, 2024

@renintw would you mind taking a quick look at this when you get a chance?

@dd32
Copy link
Member

dd32 commented Dec 11, 2024

Due to events having Badges perhaps this should be labeled Profile Badges to properly explain what they are?

@pkevan
Copy link
Contributor Author

pkevan commented Dec 11, 2024

Due to events having Badges perhaps this should be labeled Profile Badges to properly explain what they are?

good point - i'll add some specific language around on the tool page and adjust the menu item accordingly so there isn't confusion.

@ePascalC
Copy link

ePascalC commented Dec 11, 2024

@pkevan Why would this be a submenu under Tickets? If this is to only add badges for attendees, then it would fit there. But if this module will also be used for Volunteers, like I see in the code, then it seems the wrong place in the menu.

Also please use https://developer.wordpress.org/reference/functions/validate_username/ just to ensure correct wordpress.org usernames (unless Profiles\badge_api is already doing this)

@pkevan
Copy link
Contributor Author

pkevan commented Dec 12, 2024

Why would this be a submenu under Tickets? If this is to only add badges for attendees, then it would fit there. But if this module will also be used for Volunteers, like I see in the code, then it seems the wrong place in the menu.

There isn't really a suitable place for this to go, hence it's location.

Initially I was going to add multiple badges to the interface which was why it ended up related to Camptix's menus.

@pkevan pkevan merged commit 3d5ebd7 into production Dec 12, 2024
3 checks passed
@pkevan pkevan deleted the add/badges branch December 12, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] CampTix Including addons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow badges to be created by event organisers
3 participants