Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit tickets without needing to log in. #1405

Conversation

StevenDufresne
Copy link
Contributor

Related: #1393

WordPress.org accounts were added as a requirement for purchasing tickets.

Since this feature was added after users purchased tickets the old way, there can be a mismatch between the attendee associated with the ticket and the logged-in account. This PR removes the need to log in to edit the ticket. This returns it to previous functionality.

Props MarcZijderveld

This should be removed in the future when there are no more tickets sold without wp.org accounts.

@StevenDufresne StevenDufresne marked this pull request as ready for review October 21, 2024 04:06
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting that I don't think we strictly need to validate whether they have an edit/access token or not, since they'll either have one, have access through an account, or just end up in a dead end.

@StevenDufresne StevenDufresne requested a review from pkevan October 22, 2024 01:22
Copy link
Contributor

@pkevan pkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StevenDufresne StevenDufresne merged commit 6a94ae2 into WordPress:production Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants