Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ticket messaging when camp is closed. #1404

Merged

Conversation

StevenDufresne
Copy link
Contributor

Related: #1403

When a WordCamp is closed, we still display messaging that appears like a ticket may be sold later. This PR updates that message to explain the camp is closed.

I also created an is_wordcamp_closed function as opposed to checking the post type so we can start to refactor. I updated the only other reference in this file as well.

Screenshots

Example: https://asia.wordcamp.org/2024/tickets/

Before After
Screenshot 2024-10-21 at 10 47 14 AM Screenshot 2024-10-21 at 10 41 45 AM

@@ -0,0 +1,74 @@
Index: camptix.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess this was included in the PR by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@StevenDufresne StevenDufresne merged commit a9519f0 into WordPress:production Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants