Events: Better date for the table. #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenDufresne
commented
Dec 7, 2023
| '<time class="wporg-marker-list-item__date-time" date-time="%1$s" title="%1$s"><span class="wporg-google-map__date">%2$s</span><span class="wporg-google-map__time">%3$s</span></time>', | ||
| gmdate( 'c', esc_html( $event->timestamp ) ), | ||
| gmdate( 'l, M j', esc_html( $event->timestamp ) ), | ||
| esc_html( gmdate('H:i', $event->timestamp) . ' (UTC-0)' ), |
There was a problem hiding this comment.
(UTC-0) is a bit useless and maybe it should just be UTC.
adamwoodnz
reviewed
Dec 7, 2023
public_html/wp-content/themes/wporg-events-2023/postcss/blocks/wporg-google-map.pcss
Outdated
Show resolved
Hide resolved
adamwoodnz
approved these changes
Dec 7, 2023
…/wporg-google-map.pcss Co-authored-by: Adam Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the default date (which we hope to switch out with the user locale date) to match the designs.
Design: https://www.figma.com/file/jdMk5ssz2Av7KFfEaeK7de/Events?node-id=1617%3A14095&mode=dev
I did make a couple of choices here:
Screenshots
How to test the changes in this Pull Request: