Add organizer debrief survey #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba7fa61 refactored this function, but accidentally started accessing the `Id` field before checking if the response was a `WP_Error`. That triggers a fatal error because it's treating an object like an array.
* Add new Attendees section * Tweak styles accordingly * Add Sponsor Ticket * Add per-sponsor to the calculations in expenses * Add Complimentary Tickets as an expense category
* Only show pay by check/ACH when the US is selected * Add is_visible to render_radio_input * Remove setDefaultPaymentMethod A few reasons to remove this. 1. It kind of didn't work as expected, from what is observed, it would always default to 'Wire' and doesn't change when switching to a different currency. This is because when the callback is triggered for the first time, 'USD' doesn't equal newCurrency, and therefore the 'Wire' is selected. And later when a user selects an option, triggering callback again, it would always return as 'undefined !== selectedPaymentMethod' is always true. 2. Currently, once the 'Country for payment receipt' is selected, the system lists all payment methods based on whether the chosen country is the US. After this, users pick a payment method, and only then does the relevant form for that method become visible. So even though the setDefaultPaymentMethod might work initially, it ends up auto-selecting either Wire or Direct Deposit for the user based on the currency they choose, but the desired outcome is to let users choose between Deposit or Check only when the payment receipt country is set to the US, rather than basing it on the currency.
renintw
force-pushed
the
add/debrief_survey
branch
3 times, most recently
from
34880b5 to
b76d50b
Compare
renintw
force-pushed
the
add/debrief_survey
branch
from
b76d50b to
ca7e1df
Compare
|
Closed in favor of #1038. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #930
Should be part of the New event infrastructure
Flow
Create a debrief page in draft status
Email to lead organizer
Add Admin page to central.wordpress.org
Send email after event ends 2 days
Schedule a daily cron job
CronJob
Screenshots
How to test the changes in this Pull Request: