-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sponsor Tickets #1022
Merged
Merged
Add Sponsor Tickets #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renintw
force-pushed
the
enhance/add-sponsor-attendee
branch
from
August 30, 2023 20:33
7058cfa
to
81dda3b
Compare
renintw
force-pushed
the
enhance/add-sponsor-attendee
branch
from
August 30, 2023 21:10
b1213e8
to
db209e1
Compare
renintw
force-pushed
the
enhance/add-sponsor-attendee
branch
from
August 30, 2023 21:51
11712f6
to
c61a3e2
Compare
iandunn
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
renintw
added a commit
that referenced
this pull request
Sep 6, 2023
* Add new Attendees section * Tweak styles accordingly * Add Sponsor Ticket * Add per-sponsor to the calculations in expenses * Add Complimentary Tickets as an expense category
renintw
added a commit
that referenced
this pull request
Sep 11, 2023
* Add new Attendees section * Tweak styles accordingly * Add Sponsor Ticket * Add per-sponsor to the calculations in expenses * Add Complimentary Tickets as an expense category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927
This PR adds
Sponsor Tickets
andComplimentary Tickets
fields as requested.Props @timiwahalahti
Screencasts
sponsor.ticket.mp4
How to test the changes in this Pull Request:
Attendees
next toEvent Data
.Attendees
section,Sponsor Tickets
should be there.Expenses > Amount
entries, you should seeper sponsor
andper attendee+sponsor
.Expenses
andCost Per Person
in theSummary
section should reflect correctly on whatever number or amount you enter forSponsor Tickets
and amount inExpenses > Amount
enries.Expense > Category
, you should be able to add a new categoryComplimentary Tickets
.