TT1 Blocks: Re-create the "Let's Connect" pattern with custom borders instead of a block style. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
reviewed
Aug 19, 2021
tt1-blocks/theme.json
Outdated
Comment on lines
14
to
19
| "border": { | ||
| "customColor": true, | ||
| "customRadius": true, | ||
| "customStyle": true, | ||
| "customWidth": true | ||
| }, |
There was a problem hiding this comment.
Looks like border customizations are already enabled for the theme.
There was a problem hiding this comment.
😄 Thanks. I've removed that.
kjellr
changed the title
|
Since it turned out that custom borders were already active in the theme, I've reframed this PR as just a refresh of that single block pattern instead. |
|
It was a little odd that the padding was in the columns and not in the group.
When I first dropped it in I tried to tweak that at the top level container and found I couldn't make it any smaller. That's my only complaint though. If there's a reason to pad the columns instead it's reason enough for me. Looks good otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-creates the "Let's Connect" pattern to use the custom borders feature instead of the old custom block style.
None of the other border patterns can be replaced yet, since the border settings required are only available for the Group block presently.