Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus Mode: Hide Block Outlines #9394

Merged
merged 16 commits into from
Aug 30, 2018
Merged

Focus Mode: Hide Block Outlines #9394

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d214452
More Menu: Rename the "Fixed toolbar to the top" into "Focus Mode"
youknowriad Aug 28, 2018
daaadd1
Hide Block Outlines in Focus Mode
youknowriad Aug 28, 2018
50e47b0
Separate the two options "Fixed Toolbar to Top" and "Focus Mode"
youknowriad Aug 29, 2018
baa9c71
Focus Mode: Unfocus the unselected blocks
youknowriad Aug 29, 2018
05769a5
Fix toolbar position and nested focused blocks
youknowriad Aug 29, 2018
ce86cac
Animate opacity transitions
youknowriad Aug 29, 2018
fdbcd89
Rename the writing options
youknowriad Aug 30, 2018
e55fb0a
Avoid focus mode on multi-selected blocks
youknowriad Aug 30, 2018
6388348
Fix FeatureToggle label
youknowriad Aug 30, 2018
d573e40
Lighter UI for the fixed toolbar
youknowriad Aug 30, 2018
2de3bab
Slightlty quicker focus animation
youknowriad Aug 30, 2018
9ad5b0a
Fix the post title in both modes
youknowriad Aug 30, 2018
32552f6
Hide the movers in Spotlight mode
youknowriad Aug 30, 2018
1a81e49
Fix block deletion e2e test
youknowriad Aug 30, 2018
ef3abd1
Fix post title focus when typing
youknowriad Aug 30, 2018
95520a4
Fix multi-selection contextual toolbar in focus mode
youknowriad Aug 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/specs/block-deletion.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe( 'block deletion -', () => {

describe( 'deleting the third block using the Remove Block shortcut', () => {
it( 'results in two remaining blocks and positions the caret at the end of the second block', async () => {
await pressWithModifier( [ 'Shift', META_KEY ], 'x' );
await pressWithModifier( [ 'Shift', META_KEY ], 'Backspace' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the e2e tests because this was not updated. Not sure when this shortcut changed but was left as is in the e2e tests

cc @talldan @jasmussen

This is the right shortcut to delete the block, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Yeah would be nice to have @talldan answer here. I know that the backspace keyboard combo needs to be changed, but a different change was also merged in and later reverted. Perhaps this PR was created before the latter change was reverted? I'm pretty sure it's Backspace in master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I checked the code and it's backspace, and I saw the revert commit but for some reason the revert didn't revert the e2e test and it wasn't failing in e2e tests. Maybe the e2e test was added in parallel.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowriad Sorry about that, the test was added in parallel, but I missed reverting it back before flying out to our meetup. Here's a PR that should fix things:
#9477

expect( await getEditedPostContent() ).toMatchSnapshot();

// Type additional text and assert that caret position is correct by comparing to snapshot.
Expand Down