Move MoreMenu-specific styling away from Popover CSS #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves CSS rules that are specific to styling the MoreMenu component out of the Popover CSS file and into the MoreMenu's CSS file. This fixes DotTips from appearing too narrow, and should prevent other components that use Popover from being inadvertently styled differently.
|
Thanks for wrangling this @jasmussen! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was graciously written by @noisysocks, to fix a regression I introduced in #8756. It was done, and Robert was opening the PR as I came online without enough coffee and thought the fix should be slightly different to what Robert was proposing. As is so often the case, he was right all along. My thanks to Robert for fixing this.
In #8756, the change was made to the popover component in order to let all menus using this component grow and shrink as necessary. However with the addition of a whitespace rule, this only really made sense for menu items inside popovers, not all popovers. This PR moves things around to be where they're supposed to be.
Roberts original text:
Moves CSS rules that are specific to styling the MoreMenu component out
of the Popover CSS file and into the MoreMenu's CSS file. This fixes
DotTips from appearing too narrow, and should prevent other components
that use Popover from being inadvertently styled differently.