Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slot to render block settings in the inspector. #731

Merged
merged 1 commit into from
May 15, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented May 9, 2017

image

@mtias mtias added [Feature] Block API API that allows to express the block paradigm. General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress labels May 9, 2017
@youknowriad
Copy link
Contributor

With #714 It should be easier to extract the attributes, their types and any relative information about the attribute to show in the inspector.

@mtias
Copy link
Member Author

mtias commented May 9, 2017

Yes, I'm trying to think what would be the best way to declare whether something appears in the regular toolbar, on the inspector, or on both.

@youknowriad
Copy link
Contributor

I think the "chaining API" might be a good solution.

attributes: {
  align: metadata().isString().choices( [ 'left', 'right', 'center', 'none' ] ).description( 'Text alignment' )
  content: children().hideFromInspector()
}

We could automatically generate the form based on this

@mtias
Copy link
Member Author

mtias commented May 9, 2017

Perhaps, but maybe the opposite is better: showOnInspector and defaulting to hide? We also need to figure out the simplest way to provide controls for these (inputs, toggles, segmented controls, etc).

@jasmussen
Copy link
Contributor

Yes, I'm trying to think what would be the best way to declare whether something appears in the regular toolbar, on the inspector, or on both.

What if we always show a copy of the Quick Toolbar at the top of the inspector, like @folletto proposed, and then show advanced settings below that. There should be room. Would that make life simpler?

@aduth
Copy link
Member

aduth commented May 9, 2017

Would a chainable API provide much benefit over a function which returns either an element or an array of field descriptions? I worry whether it'd be flexible enough, and if it's truly any more developer-friendly.

@youknowriad
Copy link
Contributor

Let's move the discussion about the API here #714 (comment)

@mtias mtias force-pushed the add/block-inspector-settings branch from 1b0efd6 to 7ead8a9 Compare May 15, 2017 17:36
@mtias mtias force-pushed the add/block-inspector-settings branch from 7ead8a9 to fb9a1f6 Compare May 15, 2017 17:37
@mtias
Copy link
Member Author

mtias commented May 15, 2017

Going to merge this as a placeholder for the functionality as we figure out how to present it.

@mtias mtias merged commit de4822b into master May 15, 2017
@mtias mtias deleted the add/block-inspector-settings branch May 15, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. General Interface Parts of the UI which don't fall neatly under other labels. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants