-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Slot to render block settings in the inspector. #731
Conversation
mtias
commented
May 9, 2017
With #714 It should be easier to extract the attributes, their types and any relative information about the attribute to show in the inspector. |
Yes, I'm trying to think what would be the best way to declare whether something appears in the regular toolbar, on the inspector, or on both. |
I think the "chaining API" might be a good solution. attributes: {
align: metadata().isString().choices( [ 'left', 'right', 'center', 'none' ] ).description( 'Text alignment' )
content: children().hideFromInspector()
} We could automatically generate the form based on this |
Perhaps, but maybe the opposite is better: |
What if we always show a copy of the Quick Toolbar at the top of the inspector, like @folletto proposed, and then show advanced settings below that. There should be room. Would that make life simpler? |
Would a chainable API provide much benefit over a function which returns either an element or an array of field descriptions? I worry whether it'd be flexible enough, and if it's truly any more developer-friendly. |
Let's move the discussion about the API here #714 (comment) |
1b0efd6
to
7ead8a9
Compare
7ead8a9
to
fb9a1f6
Compare
Going to merge this as a placeholder for the functionality as we figure out how to present it. |