Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Add Layout Support #68485

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

shail-mehta
Copy link
Member

What?

Added Layout support to the Comments Block.

Part of : #43248

Why?

The block was missing Layout Support Features.

Testing Instructions

  • Add Comments Block in Single Posts Template or Page/Post .
  • Enable Inner blocks use content width Option.
  • Also Check With layout width in Layout Settings
  • Check Settings in Editor and Frontend Side

Screenshots or Screencast

comments-layout-support.mp4

@shail-mehta shail-mehta added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jan 4, 2025
@shail-mehta shail-mehta self-assigned this Jan 4, 2025
@shail-mehta shail-mehta added the [Feature] Layout Layout block support, its UI controls, and style output. label Jan 4, 2025
Copy link

github-actions bot commented Jan 4, 2025

Flaky tests detected in 39cb72c.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12608026563
📝 Reported issues:

@shail-mehta shail-mehta marked this pull request as ready for review January 4, 2025 06:31
Copy link

github-actions bot commented Jan 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: aaronrobertshaw <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label Jan 4, 2025
@aaronrobertshaw aaronrobertshaw removed their request for review January 6, 2025 03:56
@aaronrobertshaw
Copy link
Contributor

Thanks for the PR @shail-mehta 👍

As noted on a couple of your other recent support PRs, I don't have the bandwidth for reviews in the near future.

Can you please clarify the test instructions on this PR so that anyone regardless of context, can help review?

@shail-mehta
Copy link
Member Author

Thanks for the feedback. I will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants