Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, round two #68482

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Fix typos, round two #68482

wants to merge 4 commits into from

Conversation

szepeviktor
Copy link
Contributor

What?

New misspellings found.

Copy link

github-actions bot commented Jan 3, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: szepeviktor <[email protected]>
Co-authored-by: michalczaplinski <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jan 3, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @szepeviktor! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 3, 2025
@szepeviktor
Copy link
Contributor Author

@michalczaplinski These are the remaining misspellings.

@michalczaplinski
Copy link
Contributor

Thanks @szepeviktor

This looks good. However, this file should not be renamed without also updating its references: packages/block-editor/src/components/alignment-control/stories/alignment-toolbar.story.js. I suspect it's also the reason why the unit test fails.

@michalczaplinski michalczaplinski self-requested a review January 6, 2025 19:56
Copy link
Contributor

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to rename packages/block-editor/src/components/alignment-control/stories/alignment-toolbar.story.js, we should update every reference to that file.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 6, 2025

rename from packages/block-editor/src/components/alignment-control/stories/aliginment-toolbar.story.js
  rename to packages/block-editor/src/components/alignment-control/stories/alignment-toolbar.story.js

I could not find "aliginment" in the repo. Please help me.

@michalczaplinski michalczaplinski added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 6, 2025
@michalczaplinski
Copy link
Contributor

My bad, you're right; that file is not referenced elsewhere. It's only used by Storybook.

I'm not sure why there is a unit test failure after all. I'll re-run the check but just letting you know that I'll have limited time in coming weeks to review PRs, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants