Fix CSS classes for the post editor iframe body. #68481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60299
Second attempt to fix this issue after #60300 was reverted for a bug in Safari, see #60616. A follow-up was planned but it never happened.
What?
In the post editor, the
is-dark-themeCSS class gets removed from the iframe body when the iframe fully loads. This happens only in the post editor, it doesn't in the site editor as the implementation is different.Why?
The
is-dark-themeCSS class is necessary to correctly style some UIs when a dark theme is in use.For example, for accessibility, the block placeholder text should use a sufficient contrast ratio when the theme is dark.
How?
Moves setting the iframe body classes at an earlier time in
useRefEffectrather than in the iframeonLoadcallback.I'm not sure there was a specific reason to set the classes after the iframe is fully loaded. The
onLoadcallback appears to be too late, as at that point the existing classes get replaced.In this PR the setting of the classes happens earlier, in the
useRefEffecthook. It appears everything works as expected because at that point the iframe element is rendered. Theoretically there shouldn't be drawbacks but please double check any potential undesired side effect.Cc @glendaviesnz @ellatrix
Testing Instructions
Reproduce the issue on trunk:
loadevent takes a while to fire.block-editor-iframe__bodyto check the intial classes before the iframe fully loads are:block-editor-iframe__body editor-styles-wrapper is-dark-themeblock-editor-iframe__body editor-styles-wrapper post-type-post admin-color-fresh wp-embed-responsiveis-dark-themeclass is now missing.block-editor-iframe__body editor-styles-wrapper post-type-post admin-color-fresh wp-embed-responsive is-dark-themeis-dark-themeclass isstill there.and observe theadmin-color-freshclass is nowadmin-color-midnight`.post-type-postclass is nowpost-type-pag.Testing Instructions for Keyboard
Screenshots or screencast