Navigation Submenu Block: Add dropdown menu props to ToolsPanel component #68015
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hey @fabiankaegy, Would it be a good idea to create a single PR to add all the dropdown menu props? I realize it’s going to take a lot of PRs, and this fix can be done in one PR. What do you think about this? If you agree, I can create a single PR to fix this for all the PRs that have already been merged. Thank you |
|
@im3dabasia Yeah happy to also review one that patches all the instances we were missing initially |
Sure I will add that in one PR |
|
Hi @talldan, could you please review this PR when you have a moment? |
talldan
added
[Type] Bug
| @@ -394,6 +396,7 @@ export default function NavigationSubmenuEdit( { | |||
| rel: '', | |||
| } ); | |||
There was a problem hiding this comment.
I think it might be worth reconsidering what resetting some of these attributes means.
In a lot of cases, the block will have a post id (also kind and type), meaning it's linked to a particular post, and I think reset could set the value back to that post's title. Resetting to an empty string is quite destructive in that situation.
It'll take a bit of work as there's no code in the block at the moment to make that happen so it's something that can be handled in a separate PR/issue.
I think @getdave might be looking at some related issues at the moment.
Follows up: #67969
What?
Enhances the Navigation Submenu block's ToolsPanel by adding support for dropdown menu functionality through the useToolsPanelDropdownMenuProps hook.