Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionItem.Slot: Render as MenuGroup by default #67985

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
+8 −4
Open

ActionItem.Slot: Render as MenuGroup by default #67985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb8a708
ActionItem.Slot: Render as MenuGroup by default
mirka Dec 13, 2024
578b2d6
Add changelog
mirka Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/interface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Changes

- `ActionItem.Slot`: Render as `MenuGroup` by default ([#67985](https://github.com/WordPress/gutenberg/pull/67985)).

## 8.3.0 (2024-12-11)

## 8.2.0 (2024-11-27)
Expand Down
4 changes: 2 additions & 2 deletions packages/interface/src/components/action-item/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ Property used to change the event bubbling behavior, passed to the `Slot` compon

### as

The component used as the container of the fills. Defaults to the `ButtonGroup` component.
The component used as the container of the fills. Defaults to the `MenuGroup` component.

- Type: `Component`
- Required: no
- Default: `ButtonGroup`
- Default: `MenuGroup`

## ActionItem

Expand Down
4 changes: 2 additions & 2 deletions packages/interface/src/components/action-item/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
/**
* WordPress dependencies
*/
import { ButtonGroup, Button, Slot, Fill } from '@wordpress/components';
import { MenuGroup, Button, Slot, Fill } from '@wordpress/components';
import { Children } from '@wordpress/element';

const noop = () => {};

function ActionItemSlot( {
name,
as: Component = ButtonGroup,
as: Component = MenuGroup,
fillProps = {},
bubblesVirtually,
...props
Expand Down
Loading