Add Post Type Archive in Link UI and Navigation Link via Types API endpoint #67793
+112
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Feature] Link Editing
getdave
requested review from
TimothyBJacobs,
spacedmonkey,
ajitbohra and
nerrad
as code owners
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
1 similar comment
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
getdave
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews, @gwwar, @mgratch, @walton-alex, @nathan-schmidt-viget, @Bricobit. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
changed the title
|
Size Change: +172 B (+0.01%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
getdave
commented
Dec 10, 2024
getdave
commented
Dec 10, 2024
| .filter( ( result ) => !! result.archive_link ) // Filter out results with falsy archive_link, including empty strings | ||
| .map( ( result, index ) => { | ||
| return { | ||
| id: index + 1, // avoid results being filtered due to falsy id |
There was a problem hiding this comment.
Having to use a manual id isn't ideal here.
getdave
force-pushed
the
try/post-type-archive-search-types-api
branch
2 times, most recently
from
aedb880 to
9d95779
Compare
fabiankaegy
reviewed
Dec 12, 2024
jonnynews
suggested changes
Dec 12, 2024
packages/core-data/src/fetch/__experimental-fetch-link-suggestions.ts
Outdated
Show resolved
Hide resolved
That's a good start 👍 Confirming we're providing the correct functionality is useful to allow us to refine the implementation here and include tests...etc. Thank you. |
getdave
force-pushed
the
try/post-type-archive-search-types-api
branch
from
61c4d87 to
88142ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #66821.
Provides ability to link to Post Type Archives via the Link UI.
Closes #31452
Why?
Parity with Classic Menus where you could search for and add links to the Post Type Archives.
This also ensures that when visiting the Archives pages the current-menu-item class is added to the menu item.
How?
Note: I appreciate that the extension to the Types endpoint will need to be undertaken in Core.
Testing Instructions
Please follow testing steps from #66821.
Testing Instructions for Keyboard
Screenshots or screencast