Inline commenting: Comment board alignment to relative blocks #67622
+283
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +6.21 kB (+0.34%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
|
@ellatrix I might need your help with this one. I have aligned the comment board with the respective block. How do I get the sidebar to scroll with the editor now? |
|
Could you try adding a scroll event listener? Or maybe try to use |
Thank you @ellatrix , ill check these.
That's the intent.
Yes, I have noticed it too and its in my list. |
…nline-commenting-comment-board-position
|
This is how it works now. Edit-Post-.Inline-commenting-test.-.-gutenberg-.-WordPress.webm |
…nline-commenting-comment-board-position
…nline-commenting-comment-board-position
…nline-commenting-comment-board-position
…nline-commenting-comment-board-position
|
Flaky tests detected in 76a34b1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12592521916
|
…nline-commenting-comment-board-position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of - #66377
What? & Why?
Following the designed provide in #66377, This PR aligns the comment board with the corresponding block element and ensures the comment board scrolls along with the editor.
Along with this, Few more fixes/enhancements done in this PR are below:
Testing Instructions
Gutenberg → ExperimentsScreenshots or screencast