Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Fixes Aligned Images size in Lightbox #67528

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

What?

Fixes #66692

Why?

This PR fixes the position and size of images in the Image blocks of themes without a json file.

How?

Updated the function gutenberg_restore_image_outer_container so that the lightbox does not affect the position and image size.

Testing Instructions

  1. Log in to the WordPress Dashboard with administrator credentials.
  2. Activate a classic theme without theme.json (e.g., Twenty Twenty-One or Twenty Nineteen).
  3. Create a new page and add an Image block.
  4. Select or upload an image in the Image block.
  5. Enable the "Expand on click" option by clicking the link option.
  6. Align the image to center, left or right using the align option.
  7. Save or publish the page.
  8. Open the page on the frontend.
  9. Click the image to open the lightbox.
  10. Verify that the lightbox displays the image in correct position and original image size correctly.

Testing Instructions for Keyboard

Screenshots or screencast

After the fix

REC-20241203202428.mp4

Copy link

github-actions bot commented Dec 3, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: rohitmathur-7 <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Block: Aligned images do not display lightboxes correctly in Classic theme
1 participant