Zoom out: fix for inserter #67495
Merged
Zoom out: fix for inserter #67495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -32 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Thanks @ellatrix! |
This was referenced Dec 2, 2024
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
Makes previousIsZoomedOut a proper ref, and assumes a starting zoom level of 1.
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Makes previousIsZoomedOut a proper ref, and assumes a starting zoom level of 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After #67481, zoom-out is broken for the pattern inserter.
Why?
A regression.
How?
#67481 has two problems:
undefinedtofalse.I've moved it to a proper ref and added a default value of
false, though this might wrongly assume that the initial zoom-out state is false.I would be better to move all this logic with the iframe component so we don't need to do the document check at all.
Testing Instructions
Toggle zoom-out through the button and the pattern inserter.
Testing Instructions for Keyboard
Screenshots or screencast