Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add BorderRadiusControl story #67383

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

Sukhendu2002
Copy link
Contributor

@Sukhendu2002 Sukhendu2002 commented Nov 28, 2024

Part of #67165

What?

This PR will add stories for BorderRadiusControl component in the Storybook.

Testing Instructions

  1. Run npm run storybook:dev
  2. Open the storybook on http://localhost:50240/
  3. Check the BorderRadiusControl stories.

Screenshots or screencast

Screenshot 2024-12-02 at 4 59 34 PM

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review November 28, 2024 10:34
Copy link

github-actions bot commented Nov 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Sukhendu2002
Copy link
Contributor Author

Hi @t-hamano, I’ve updated the PR to include the suggested changes for improving code consistency. Feel free to take a look whenever you have time. Thanks!

@t-hamano t-hamano self-requested a review December 12, 2024 12:52
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I noticed that this component doesn’t have a README.

I believe that every component published to Storybook should have a README so that developers can easily implement the component (See #22891).

If you don’t mind, could you work on creating the README first? Feel free to contact me once the PR is complete 👍

Thank you!

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants