Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Bump minimum required WordPress version to 6.6 #67117

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 19, 2024

What?

Similar to #64126.

Bumps the "Required WP version" field to 6.6, and the "Tested up to" field to 6.7. It also updates the performance test base hash.

Why?

To reflect the current WP version, and update the minimum required version to the previous one.

I'd also like to unblock #64676 😬

How?

See https://developer.wordpress.org/block-editor/explanations/architecture/performance/#update-the-reference-commit

Testing Instructions

  • CI checks should be green.
  • Confirm that new commit SHA matches guidelines.

@ockham ockham added [Type] Enhancement A suggestion for improvement. Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts labels Nov 19, 2024
@ockham ockham requested a review from a team November 19, 2024 14:33
@ockham ockham self-assigned this Nov 19, 2024
@ockham ockham requested a review from desrosj as a code owner November 19, 2024 14:33
@ockham ockham requested review from scruffian and ntsekouras and removed request for a team and desrosj November 19, 2024 14:33
Copy link

github-actions bot commented Nov 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <[email protected]>
Co-authored-by: ramonjd <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: SantosGuillamot <[email protected]>
Co-authored-by: ntsekouras <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ntsekouras
Copy link
Contributor

Shouldn't we remove first (or at the same PR) the compat layer for 6.6?

@Mamaduka Mamaduka removed the [Type] Enhancement A suggestion for improvement. label Nov 19, 2024
@ockham
Copy link
Contributor Author

ockham commented Nov 19, 2024

Shouldn't we remove first (or at the same PR) the compat layer for 6.6?

Sure! I see that's what you did for 6.5 (#64096 before #64126). Looks like you also had to remove the 6.4 compat layer in #64096 since I didn't do that in #60780 🙈 So it's probably a good idea to do it at once.

I'll push a commit 👍

@ockham ockham added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Nov 19, 2024
@ramonjd
Copy link
Member

ramonjd commented Nov 20, 2024

Thanks @ockham I smoke tested the site editor and the revisions controller stuff in particular. From my perspective LGTM

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested editors and everything looks to be working correctly.

No PHP errors or warnings in logs.

Copy link

Flaky tests detected in f602432.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11929986618
📝 Reported issues:

@ockham ockham merged commit 58e2d4b into trunk Nov 20, 2024
64 checks passed
@ockham ockham deleted the update/minimum-wp-version-to-6-6 branch November 20, 2024 11:52
@desrosj
Copy link
Contributor

desrosj commented Nov 20, 2024

Just a heads up that when we bump minimum version requirements, we do need to make a Core SVN change to pin the last compatible version of the Gutenberg plugin in the E2E test workflow for any branch losing support. I've gone and opened #67167 to add this to the documentation, and Core-62488 to make this change once 19.8 enters RC phase.

@ockham
Copy link
Contributor Author

ockham commented Nov 20, 2024

TIL 😅 Thank you @desrosj!

@bph bph added the [Type] Project Management Meta-issues related to project management of Gutenberg label Nov 26, 2024
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: Gutenberg Plugin, [Type] Project Management, No Core Sync Required.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@ockham
Copy link
Contributor Author

ockham commented Dec 16, 2024

Just a heads up that when we bump minimum version requirements, we do need to make a Core SVN change to pin the last compatible version of the Gutenberg plugin in the E2E test workflow for any branch losing support. I've gone and opened #67167 to add this to the documentation, and Core-62488 to make this change once 19.8 enters RC phase.

PR here: WordPress/wordpress-develop#8008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Project Management Meta-issues related to project management of Gutenberg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants