Post Excerpt: Add border block support #64022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Flaky tests detected in 5aee5a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10125060867
|
There was a problem hiding this comment.
Thanks for the PR 👍
This tests pretty well for me. It just needs a default box-sizing: border-box style added as noted on a couple of your other block support PRs.
✅ Global styles display correctly
✅ Block instance styles override global styles
✅ Styling is consistent between editor and frontend
❌ Missing box-sizing style
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +392 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
This is working as advertised, nice job! 👍
✅ Global border styles apply correctly
✅ Block instance styles override global styles
✅ Styles are applied consistently between editor and frontend
✅ Box sizing takes into account border when parent enforces width
Screen.Recording.2024-07-30.at.6.37.50.PM.mp4
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Post Excerptblock.Part of #43247
Why?
Post Excerptblock is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Post Excerptblock's border is configurable via Global StylesPost Excerptblock and Apply the border stylesPlease refer to the attached video for more information.
Screenshots or screencast
Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.11.webm