Table of contents: Add border block support #63578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…add/tableofcontents-border-support
|
Size Change: +191 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
@aaronrobertshaw could use review here. |
aaronrobertshaw
approved these changes
Jul 29, 2024
| @@ -0,0 +1,4 @@ | |||
| :root :where(.wp-block-table-of-contents) { | |||
There was a problem hiding this comment.
I just realised belatedly that this CSS selector should be simplified. The :root :where() combo makes the specificity the same as the simple class name and probably should just be .wp-block-table-of-contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Table of contentsblock.Part of #43247
Why?
Table of contentsblock is missing border support.How?
Adds the border block support in block.json
Testing Instructions
Table of contentsblock's border is configurable via Global StylesTable of contentsblock and Apply the border stylesScreenshots or screencast
Blog-Home-.-Template-.-gutenberg-.-Editor-.-WordPress.5.webm