-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SlotFill in Status & Availability panel to match existing hook #6300
Merged
gziolo
merged 19 commits into
WordPress:master
from
ryanwelcher:feature/visbility-and-status-extensibility
May 7, 2018
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2e7164b
Merge remote-tracking branch 'upstream/master'
32e51a7
Introduce fill slot for the Status & Availbilty panel
6dc9667
lint fixes
98ff539
Changing import statements to use the @wordpress package
3139cb6
Fix to remove duplicate import
ad7631c
Removing extra whitespace
3940ad3
Fixes typo
8591618
Rename slot to PluginPostStatusInfo
1c13ac0
Structural changes and only exporting the Fill to the public api
51b72c4
Lint fixes
9da8053
Edit Post: Use PluginPostStatusInfo alias for Fill
gziolo bbc9da9
Edit Post: Fix export for the PluginPostStatusInfo
gziolo 183beaf
Adding documentation notes
28eb3a8
Merge remote-tracking branch 'upstream/master'
a9025b0
Merge branch 'master' into feature/visbility-and-status-extensibility
198a552
Fixes typo in SlotFills
1ec48fa
Changes the docs
a71c4e9
Edit Post: Update documentation for plugins
gziolo 8efddae
Edit Post: Small tweak with inline comments
gziolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
edit-post/components/sidebar/plugin-post-status-info/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* Defines as extensibility slot for the Status & Visibility panel | ||
*/ | ||
import { createSlotFill, PanelRow } from '@wordpress/components'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This import statement should have |
||
|
||
export const { Fill: PluginPostStatusInfo, Slot } = createSlotFill( 'PluginPostStatusInfo' ); | ||
|
||
PluginPostStatusInfo.Slot = () => ( | ||
<PanelRow> | ||
<Slot /> | ||
</PanelRow> | ||
); | ||
export default PluginPostStatusInfo; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: are the items above on this page also slotfills? can you check the codebase and if they are move this header section to the top of the page (eg are PluginSidebar, PluginSidebarMoreMenuItem slots)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamsilverstein the do have slots defined in them yes. Perhaps we don't need the SlotFills header and I add the note about the implementation vs location under the header for the actual slot.