-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow: remove additional wrapper around getShadowClassesAndStyles #58297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
madhusudhand
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Jan 26, 2024
Size Change: -27 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
6 tasks
madhusudhand
changed the title
Shadow: skip serialization and address feedback
Shadow: remove additional wrapper around getShadowClassesAndStyles
Jan 26, 2024
madhusudhand
added
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Jan 26, 2024
vcanales
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: f5dfbad |
cbravobernal
removed
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Jan 30, 2024
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses the feedback from here by removing additional wrapper
useShadowProps
aroundgetShadowClassesAndStyles
Partial fix for: #58298