Font Library: Prevent error when installing a system font twice #58141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecoder
added
[Type] Experimental
Merged
|
Size Change: +9 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
mikachan
approved these changes
Jan 23, 2024
creativecoder
merged commit dde2059
into
try/font-library-refactor
61 of 62 checks passed
creativecoder
added
the
Backport to Gutenberg RC
|
This PR was already in release/17.6, it seems that there is no need to backport it. @creativecoder |
cbravobernal
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent an error when installing a system font twice. See this comment for an example:
#57688 (comment)
Why?
The desired behavior for installing duplicate fonts is to handle it gracefully, and take no action rather than throwing an error.
How?
Add a check to make sure the
fontFaceproperty is only added to installed fonts when there are actual font faces (which system fonts do not have).Testing Instructions