Template Part & Query: avoid server requests on mount #57987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +255 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b20a114. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7582395152
|
Mamaduka
reviewed
Jan 19, 2024
| @@ -70,12 +68,16 @@ export const withEditBlockControls = createHigherOrderComponent( | |||
| const { attributes, name } = props; | |||
| const isDisplayed = name === 'core/template-part' && attributes.slug; | |||
|
|
|||
| if ( ! isDisplayed ) { | |||
| return <BlockEdit { ...props } />; | |||
There was a problem hiding this comment.
Should we use key here and below to avoid accidental remounting?
There was a problem hiding this comment.
When does it remount? Block names cannot change. I guess the slug can change. Maybe we should just remove that from the condition.
There was a problem hiding this comment.
Mainly to safeguard and the best practice. Remounting can have unexpected side effects - #50292.
Maybe we should just remove that from the condition.
The editor cannot display the template part in focus mode without slug, so we need this condition.
There was a problem hiding this comment.
In that case I think we need to make sure it remains the same component instance and within the same fragment. A key won't help with that I think? I changed it so it's the same instance for both conditions, and I added the key just to be sure.
There was a problem hiding this comment.
It does help when the component's position changes after the initial render. If the key is provided, React will use it as a part of the position instead of the order in the parent component.
This example won't retain the state between toggles without the key - https://codesandbox.io/p/sandbox/funny-herschel-slys5c?file=%2Fsrc%2FApp.js%3A33%2C29
Mamaduka
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Easier to review without whitespace.
Both the these blocks fetch stuff from the server for the inspector controls, even when the inspector controls are not visible.
Why?
Note that this happens after first blocks load, so this won't necessarily improve the "first block" metric, but it's of course still good to avoid all these.
Avoided:
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast