-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded margin: 0
override for Notice
component consumer
#57794
Remove unneeded margin: 0
override for Notice
component consumer
#57794
Conversation
This is because margin from the Notice component has been removed in PR WordPress#54800.
Hi @ecgan - you can find plenty of documentation about setting up your local development environment in the developer documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! These changes make sense to me, but we would also need to remove the import statements for the scss
files that were removed by this PR.
@import "./components/contrast-checker/style.scss"; |
Hi @draganescu , thanks for the link, but the problem isn't really about setting up my local development environment. It's more about how to test the changes introduced in this PR, and hence how to write the test instructions for this PR. I do not know how I can view and test the CSS code change (for before and after code change). |
@t-hamano , thanks, it slipped my mind. I noticed it caused errors in GitHub Actions. I have fixed it in |
@ecgan Thank you for updating the PR. Is it possible to rebase this PR with the latest trunk branch to merge this PR? Because currently the unit test is failing, but the latest trunk fixes it. |
@t-hamano , thanks for the note. I did a merge in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ecgan Thanks for the update! All GitHub Actions are green, let's merge 👍
What?
Closes issue #55279.
In this PR, we remove the
margin: 0
override forNotice
component in the Gutenberg repo.Why?
This is because the custom margin for the
Notice
component has been removed in PR #54800, so we don't need to have thesemargin: 0
override anymore.How?
Testing Instructions
Important note: I have not figured out a way to test my changes in the code repo in my local machine. I couldn't find documentation on this in the repo. If someone could tell me how to do this in the comment below, that would be great.
npm install
.npm run build
. It should complete successfully without any errors.Testing Instructions for Keyboard
Screenshots or screencast