Framework: Use CustomTemplatedPathPlugin updated for Webpack 4 #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
aduth
force-pushed
the
update/webpack-custom-templated-path
branch
from
65a8584 to
42be2fc
Compare
|
With |
aduth
added a commit
that referenced
this pull request
Mar 22, 2018
aduth
added a commit
that referenced
this pull request
Mar 30, 2018
aduth
pushed a commit
that referenced
this pull request
Mar 30, 2018
* Webpack 4: Try migrating to WebPack 4 * Framework: Use CustomTemplatedPathPlugin updated for Webpack 4 (#5687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges to
try/webpack4(#5267)Related: WordPress/packages#93
This pull request seeks to update the custom
CustomTemplatedPathPluginWebpack plugin to point to the newly-extracted-and-updated-for-Webpack-4@wordpress/custom-templated-path-webpack-plugin.Testing instructions:
Since
@wordpress/custom-templated-path-webpack-pluginis not yet published, and it's not possible to define an npm package as a subdirectory of a monorepo, you must use npm's symlink feature to test from the new package.In packages:
WordPress/packagesif you don't already have a local copycd packagesgit checkout add/custom-templated-path-pluginnpm lnIn Gutenberg:
git checkout update/webpack-custom-templated-pathnpm installnpm ln @wordpress/custom-templated-path-webpack-pluginnpm run buildThere should be no errors (but perhaps some warnings related to the Webpack 4 upgrade).