Replace the gutenberg_ prefix with wp_ in image block
#54678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
the
[Type] Bug
tellthemachines
requested review from
mikachan,
artemiomorales,
michalczaplinski,
ramonjd and
andrewserong
I imagine it's possibly the theme JSON class changes rather than |
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
andrewserong
approved these changes
Sep 21, 2023
|
Thanks for reviewing @andrewserong !
Oh that's probably it, yes! I just rechecked the function and barring some core-specific logic for caching when in theme dev mode, it's the same on both sides. |
|
Flaky tests detected in 9cdbce8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6256954192
|
tellthemachines
added
the
Backport to Gutenberg RC
mikachan
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Replace the `gutenberg_` prefix with `wp_` in image block * Remove gutenberg namespace from translation functions.
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: d80d932 |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the
gutenberg_namespace erroneously introduced toblock-libraryin #54509.In order for the lightbox to still work when enabled from theme.json, I had to add the function to the webpack list of functions to be renamed when built. Does this mean there are changes in
gutenberg_get_global_settingsthat need to be updated in core?Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast