Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar/ToolbarDropdownMenu Typescript Conversion #54321

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Toolbar/ToolbarDropdownMenu Typescript Conversion #54321

merged 5 commits into from
Sep 11, 2023

Conversation

margolisj
Copy link
Contributor

What?

Upgrades test file for Toolbar/ToolbarDropdownMenu to typescript.

Why?

Typescript is the only sane was to maintain a JS codebase this large.

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@margolisj margolisj requested a review from ajitbohra as a code owner September 8, 2023 21:24
@margolisj
Copy link
Contributor Author

@mirka @ciampo #35744. Like always, lmk if there are any other changes necessary. Cheers.

@ciampo ciampo mentioned this pull request Sep 9, 2023
Closed
@ciampo ciampo self-requested a review September 9, 2023 13:24
@ciampo ciampo added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Sep 9, 2023
ciampo
ciampo reviewed Sep 9, 2023
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Only needs a CHANGELOG entry (under the Internal subcategory)

@margolisj
Copy link
Contributor Author

LGTM 🚀

Only needs a CHANGELOG entry (under the Internal subcategory)

Done!

@ciampo ciampo enabled auto-merge (squash) September 11, 2023 08:20
@ciampo ciampo merged commit 0153ccc into WordPress:trunk Sep 11, 2023
49 checks passed
@github-actions github-actions bot added this to the Gutenberg 16.7 milestone Sep 11, 2023
@margolisj margolisj deleted the ToolbarDropdownMenu-typescript branch September 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@margolisj margolisj

Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
WordPress Components
Status: Done 🎉
Milestone
Gutenberg 16.7
Development

Successfully merging this pull request may close these issues.
2 participants
@margolisj @ciampo