-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
with-focus-outside: Convert to TypeScript #53980
Merged
ciampo
merged 9 commits into
WordPress:trunk
from
margolisj:HigherOrder-with-focus-outside
Sep 11, 2023
Merged
with-focus-outside: Convert to TypeScript #53980
ciampo
merged 9 commits into
WordPress:trunk
from
margolisj:HigherOrder-with-focus-outside
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Components
/packages/components
labels
Aug 29, 2023
margolisj
force-pushed
the
HigherOrder-with-focus-outside
branch
from
September 5, 2023 14:14
bd66e07
to
d7be667
Compare
ciampo
reviewed
Sep 5, 2023
packages/components/src/higher-order/with-focus-outside/index.tsx
Outdated
Show resolved
Hide resolved
…ilar to previous implementation.
margolisj
force-pushed
the
HigherOrder-with-focus-outside
branch
from
September 8, 2023 17:15
e42de20
to
42a1322
Compare
margolisj
commented
Sep 8, 2023
Rebased from trunk and responded to comments. |
ciampo
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast