Navigation block: Add core/buttons to the allowed blocks.
#53966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torounit
added
[Type] Enhancement
|
Size Change: +67 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
torounit
commented
Aug 26, 2023
| @@ -424,6 +424,7 @@ function LinkControl( { | |||
| ) } | |||
| onChange={ ( { opensInNewTab } ) => { | |||
| onChange( { | |||
| ...internalControlValue, | |||
There was a problem hiding this comment.
Fixed the disappearance of attributes such as url when open in new tab is clicked.
There was a problem hiding this comment.
Rebased now. Looks like it's working right.
torounit
force-pushed
the
add/allow-button-blocks-to-navigation
branch
from
1f52bfb to
8b15535
Compare
|
Rebased. Could you review it again? |
scruffian
approved these changes
Sep 6, 2023
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
core/buttonscan be added to innerBlocks of navigation block.fix #35924
Why?
Designs with buttons at the end of the navigation are commonly used on various websites, and you can find such themes in the WordPress theme directory. Here is an example
https://wordpress.org/themes/next-business/
https://wordpress.org/themes/gutenify-lynx/
https://wordpress.org/themes/blockverse/
https://wordpress.org also uses this type of navigation.
It is also common for menus to include buttons when the navigation is collapsed. (Like wordpress.org.)
Using a buttons block on the navigation block makes it easy to achieve these designs without writing any CSS or special classes.
How?
add to
core/buttonstoALLOWED_BLOCKS.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast