Image block: Revise lightbox UI to remove 'behaviors'

docs/reference-guides/core-blocks.md

@@ -339,7 +339,7 @@ Insert an image to make a visual statement. ([Source](https://github.com/WordPre
 
 -	**Name:** core/image
 -	**Category:** media
--	**Supports:** anchor, behaviors (lightbox), color (~~background~~, ~~text~~), filter (duotone)
+-	**Supports:** anchor, color (~~background~~, ~~text~~), filter (duotone)
 -	**Attributes:** align, alt, aspectRatio, caption, height, href, id, linkClass, linkDestination, linkTarget, rel, scale, sizeSlug, title, url, width
 
 ## Latest Comments

docs/reference-guides/theme-json-reference/theme-json-living.md

@@ -172,16 +172,6 @@ Settings related to typography.
 Generate custom CSS custom properties of the form `--wp--custom--{key}--{nested-key}: {value};`. `camelCased` keys are transformed to `kebab-case` as to follow the CSS property naming schema. Keys at different depth levels are separated by `--`, so keys should not include `--` in the name.
 
 
----
-
-### behaviors
-
-Settings related to behaviors.
-
-| Property  | Type   | Default | Props  |
-| ---       | ---    | ---    |---   |
-| lightbox | boolean | false |  |
-
 ---
 ## Styles
 

lib/class-wp-rest-global-styles-controller-gutenberg.php

@@ -302,7 +302,6 @@ public function update_item( $request ) {
 	 *
 	 * @since 5.9.0
 	 * @since 6.2.0 Added validation of styles.css property.
-	 * @since 6.4.0 Added validation of behaviors property.
 	 *
 	 * @param WP_REST_Request $request Request object.
 	 * @return stdClass|WP_Error Prepared item on success. WP_Error on when the custom CSS is not valid.
@@ -322,7 +321,7 @@ protected function prepare_item_for_database( $request ) {
 			}
 		}
 
-		if ( isset( $request['styles'] ) || isset( $request['settings'] ) || isset( $request['behaviors'] ) ) {
+		if ( isset( $request['styles'] ) || isset( $request['settings'] ) ) {
 			$config = array();
 			if ( isset( $request['styles'] ) ) {
 				if ( isset( $request['styles']['css'] ) ) {
@@ -340,11 +339,6 @@ protected function prepare_item_for_database( $request ) {
 			} elseif ( isset( $existing_config['settings'] ) ) {
 				$config['settings'] = $existing_config['settings'];
 			}
-			if ( isset( $request['behaviors'] ) ) {
-				$config['behaviors'] = $request['behaviors'];
-			} elseif ( isset( $existing_config['behaviors'] ) ) {
-				$config['behaviors'] = $existing_config['behaviors'];
-			}
 			$config['isGlobalStylesUserThemeJSON'] = true;
 			$config['version']                     = WP_Theme_JSON_Gutenberg::LATEST_SCHEMA;
 			$changes->post_content                 = wp_json_encode( $config );
@@ -367,7 +361,6 @@ protected function prepare_item_for_database( $request ) {
 	 *
 	 * @since 5.9.0
 	 * @since 6.2.0 Handling of style.css was added to WP_Theme_JSON.
-	 * @since 6.4.0 Added `behavior` field.
 	 *
 	 * @param WP_Post         $post    Global Styles post object.
 	 * @param WP_REST_Request $request Request object.
@@ -411,10 +404,6 @@ public function prepare_item_for_response( $post, $request ) { // phpcs:ignore V
 			$data['styles'] = ! empty( $config['styles'] ) && $is_global_styles_user_theme_json ? $config['styles'] : new stdClass();
 		}
 
-		if ( rest_is_field_included( 'behaviors', $fields ) ) {
-			$data['behaviors'] = ! empty( $config['behaviors'] ) && $is_global_styles_user_theme_json ? $config['behaviors'] : new stdClass();
-		}
-
 		$context = ! empty( $request['context'] ) ? $request['context'] : 'view';
 		$data    = $this->add_additional_fields_to_object( $data, $request );
 		$data    = $this->filter_response_by_context( $data, $context );
@@ -521,7 +510,6 @@ public function get_collection_params() {
 	 * Retrieves the global styles type' schema, conforming to JSON Schema.
 	 *
 	 * @since 5.9.0
-	 * @since 6.4.0 Added `behaviors` property.
 	 *
 	 * @return array Item schema data.
 	 */
@@ -535,28 +523,23 @@ public function get_item_schema() {
 			'title'      => $this->post_type,
 			'type'       => 'object',
 			'properties' => array(
-				'id'        => array(
+				'id'       => array(
 					'description' => __( 'ID of global styles config.', 'gutenberg' ),
 					'type'        => 'string',
 					'context'     => array( 'embed', 'view', 'edit' ),
 					'readonly'    => true,
 				),
-				'styles'    => array(
+				'styles'   => array(
 					'description' => __( 'Global styles.', 'gutenberg' ),
 					'type'        => array( 'object' ),
 					'context'     => array( 'view', 'edit' ),
 				),
-				'settings'  => array(
+				'settings' => array(
 					'description' => __( 'Global settings.', 'gutenberg' ),
 					'type'        => array( 'object' ),
 					'context'     => array( 'view', 'edit' ),
 				),
-				'behaviors' => array(
-					'description' => __( 'Global behaviors.', 'default' ),
-					'type'        => array( 'object' ),
-					'context'     => array( 'view', 'edit' ),
-				),
-				'title'     => array(
+				'title'    => array(
 					'description' => __( 'Title of the global styles variation.', 'gutenberg' ),
 					'type'        => array( 'object', 'string' ),
 					'default'     => '',
@@ -614,7 +597,6 @@ public function get_theme_item_permissions_check( $request ) { // phpcs:ignore V
 	 * Returns the given theme global styles config.
 	 *
 	 * @since 5.9.0
-	 * @since 6.4.0 Added value for `behaviors` rest field.
 	 *
 	 * @param WP_REST_Request $request The request instance.
 	 * @return WP_REST_Response|WP_Error
@@ -642,11 +624,6 @@ public function get_theme_item( $request ) {
 			$data['styles'] = isset( $raw_data['styles'] ) ? $raw_data['styles'] : array();
 		}
 
-		if ( rest_is_field_included( 'behaviors', $fields ) ) {
-			$raw_data          = $theme->get_raw_data();
-			$data['behaviors'] = isset( $raw_data['behaviors'] ) ? $raw_data['behaviors'] : array();
-		}
-
 		$context = ! empty( $request['context'] ) ? $request['context'] : 'view';
 		$data    = $this->add_additional_fields_to_object( $data, $request );
 		$data    = $this->filter_response_by_context( $data, $context );

lib/class-wp-theme-json-gutenberg.php

@@ -331,7 +331,6 @@ class WP_Theme_JSON_Gutenberg {
 		'templateParts',
 		'title',
 		'version',
-		'behaviors',
 	);
 
 	/**
@@ -416,7 +415,6 @@ class WP_Theme_JSON_Gutenberg {
 			'textTransform'  => null,
 			'writingMode'    => null,
 		),
-		'behaviors'                     => null,
 	);
 
 	/**