Try patterns server side pagination #52396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
the
[Feature] Patterns
92 tasks
|
Size Change: +1.03 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f884bf1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5481911069
|
kevin940726
force-pushed
the
try/patterns-server-side-pagination
branch
from
f884bf1 to
4e70212
Compare
kevin940726
commented
Jul 9, 2023
| * | ||
| * @return array Updated array of arguments for WP_Query. | ||
| */ | ||
| function gutenberg_rest_wp_block_query( $args, $request ) { |
There was a problem hiding this comment.
This patch adds the ability to pass sync_status query parameter to the /wp/v2/blocks api. Allowed values for now are fully and unsynced.
| // Refetch total pages when `patterns` changes. | ||
| // This is not a good indicator of when to refetch the total pages, | ||
| // but the only one we have for now. | ||
| useEffect( () => { |
There was a problem hiding this comment.
This is not fine-tuned. It currently will fire a lot of requests since we're not sure when to fetch this info. A more elegant solution will be baking this into getEntityRecords somehow. The REST API already supports this by returning the X-Wp-Totalpages response header. However, getEntityRecords (and apiFetch under the hood) doesn't support it yet. It might require multiple levels of coordination across different packages to implement this though.
| ); | ||
|
|
||
| return ( | ||
| <HStack spacing={ 2 } alignment="center"> |
There was a problem hiding this comment.
We need to revisit the styling and accessibility 😅.
| @@ -39,7 +40,9 @@ export function RouterProvider( { children } ) { | |||
|
|
|||
| useEffect( () => { | |||
| return history.listen( ( { location: updatedLocation } ) => { | |||
| setLocation( getLocationWithParams( updatedLocation ) ); | |||
| startTransition( () => { | |||
There was a problem hiding this comment.
This is not needed. I was just playing with the idea and forgot to delete it 😅 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #52303.
WIP
Why?
WIP
How?
WIP
Testing Instructions
WIP
Testing Instructions for Keyboard
WIP
Screenshots or screencast