Block Library: Unify block title with a strict title case #51912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
block/title-case
branch
from
c4c50c4 to
e33934f
Compare
|
Size Change: +7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
priethor
added
[Focus] Accessibility (a11y)
t-hamano
force-pushed
the
block/title-case
branch
from
72b522e to
ae3f479
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
block/title-case
branch
from
ae3f479 to
26a767a
Compare
t-hamano
force-pushed
the
block/title-case
branch
from
c0c76c7 to
f6ea472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates the block title according to the following title rules
Why?
I think it makes sense to apply the same rules to the same features, values, or properties.
The rules regarding capitalization are clearly stated in Copy Guidelines. I wasn't sure whether the block name should be sentence capitalization or title capitalization, but it appears that historically title capitalization has been used.
How?
I have applied the two rules listed at the beginning to the block title. We have corrected the failed tests accordingly.
Testing Instructions
Insert/Search the block that this PR has made changes to on the block editor and confirm that it appears with the correct label.