State: Set new post status to draft in initialization #5089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4956 (review)
This pull request seeks to simplify the behavior for setting a new post's status to draft, taking advantage of existing mechanisms put in place for setting the "Auto Draft" title to an empty string. This has the advantage of removing several ad-hoc checks, and avoids both the dispatch itself, but more importantly the creation of an undo level during the first save (since the
EDIT_POST
action is considered a change to undo).We can still rely on the behavior of
isEditedPostNew
to check thecurrentPost.status
, which will reflect the saved value prior to the initialization action settingedits
values. This has been reflected in updated unit tests simulating a real-world scenario.Testing instructions:
Verify that there are no regressions in the behavior of saving a new post. Notably: