Cover: Re-instate overflow:hidden rule to fix issue with border radius #50209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Regression
andrewserong
added
the
Backport to Gutenberg RC
andrewserong
requested review from
glendaviesnz,
apeatling,
ramonjd,
noisysocks and
tellthemachines
|
Size Change: +29 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
May 1, 2023
andrewserong
force-pushed
the
fix/cover-border-radius-issue
branch
from
2ab670f to
aeaf491
Compare
|
Thanks @andrewserong 🙏 |
|
I just cherry-picked this PR to the release/15.7 branch to get it included in the next release: 1734bcf |
bph
pushed a commit
that referenced
this pull request
May 2, 2023
bph
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a regression introduced by #49913 by partially reverting it.
Re-instate
overflow: hiddenin the Cover block, to fix the issue where border radius doesn't get applied to the child background element of the Cover block, as reported in #49913 (comment).Why?
The
overflow: hiddenrule was removed in order to support sticky position blocks at non-root positions, however the removal caused a regression for border radius. Sticky position at non-root positions has not yet been enabled (it's a work in progress over in #49321), so for now, let's fix the regression, which should give a bit more time to come up with another solution that might allow for both cases (Cover blocks with rounded borders and sticky children).How?
overflow: hiddenrule to the Cover block's CSSTesting Instructions
Screenshots or screencast