ColorPicker: TypeScript refactor #49214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
commented
Mar 20, 2023
chad1008
commented
Mar 21, 2023
chad1008
commented
Mar 21, 2023
chad1008
commented
Mar 21, 2023
chad1008
changed the title
ciampo
reviewed
Mar 22, 2023
ciampo
reviewed
Mar 23, 2023
ciampo
reviewed
Mar 23, 2023
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in b0e9423. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4503717638
|
chad1008
changed the title
|
Addressed latest feedback and updated PR to no longer be a draft |
chad1008
added
[Type] Code Quality
chad1008
force-pushed
the
refactor/ColorPicker-typescript
branch
2 times, most recently
from
7b40ebf to
b3d6b61
Compare
chad1008
commented
Mar 23, 2023
| @@ -31,13 +31,13 @@ The current color value to display in the picker. Must be a hex or hex8 string. | |||
|
|
|||
| ### `onChange`: `(hex8Color: string) => void` | |||
|
|
|||
| Fired when the color changes. Always passes a hex8 color string. | |||
| Fired when the color changes. Always passes a hex or hex8 color string. | |||
There was a problem hiding this comment.
onChange previously always passed a hex8 string, but since #35562, Colord.toHex() will return a hex or a hex8 (hex8 only if the color's alpha is < 1)
ciampo
force-pushed
the
refactor/ColorPicker-typescript
branch
from
b3d6b61 to
ff362ff
Compare
ciampo
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor
ColorPickercomponent's tests and stories to TypeScriptPart of #35744
Why?
The refactor to TypeScript has many benefits (auto-generated docs, static linting and error prevention, better IDE experience). See #35744 for more details
For
ColorPicker, the component itself is already written in TypeScript, tests and stories are all that need to be fully refactored.How?
Followed the steps in the TypeScript migration guide
Testing Instructions