Duotone: add block controls on the inspector #48405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
the
[Feature] Design Tools
|
Size Change: +382 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
MaggieCabrera
commented
Mar 7, 2023
MaggieCabrera
force-pushed
the
filter-inspector-panel
branch
from
0815dd4 to
dda0cef
Compare
|
Flaky tests detected in 8577539. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4618012053
|
MaggieCabrera
force-pushed
the
filter-inspector-panel
branch
from
dda0cef to
8577539
Compare
youknowriad
reviewed
Apr 5, 2023
| /> | ||
| </BlockControls> | ||
| <> | ||
| <InspectorControls |
There was a problem hiding this comment.
Instead of doing this, you should check how the other panels (typography, border, color) do it (reuse the panels used in global styles). Basically this should use the new FiltersPanel that I added in my PR, instead of rendering DuotoneControl directly.
There was a problem hiding this comment.
thanks for pointing that out! I just rebased your PR, this still needs a lot of work, but I'll look into that
|
This PR tries to do too many things at once, I'm going to break it in two: #49838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a WIP and it's not ready for review.
This PR aims to simplify the Duotone picker that shows on the block Toolbar and have the full controls appear on the Inspector controls. The option to create a custom duotone will be exclusive to the inspector to free space on the toolbar popover as discussed in #39452
Part of #39452
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast