WIP: List View: Try alternate approach to modifying the shortcut to focus while open #47901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
andrewserong
added
the
[Feature] List View
|
Size Change: +201 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Closing out this PR now as #45135 appears to be viable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧
This is a throwaway PR based on #45135 to explore a slight alternative to the focusing behaviour. The goal in this PR is to see if, while the list view is open, we can ensure that focus is always given to the selected block in the list view when using the keyboard shortcut to open the list view.
Note: this PR likely isn't really correct, as the tests introduced in #45135 are currently failing
Why?
Based on testing #45135 it seemed that focus wasn't always given to the selected item in the list view, which resulted in tests failing.
How?
Testing Instructions
Follow the testing instructions in #45135
Testing Instructions for Keyboard
Screenshots or screencast