Mobile - Fix Experiments native variant breakage #47792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 168bb9f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4105903867
|
|
@geriux looks like the iOS E2E tests failed 😭, not sure if was caused due to flakiness or not. I checked the video captured during the test and noticed that the editor froze when rendering the content until the test timed out. I've seen this issue on past failed test runs but I don't know what's the culprit.
|
Interesting! I'll check it out. |
|
Hey @fluiddot 👋 I'm working on another PR to fix the mobile E2E tests, It'd be awesome if we can merge this one that actually breaks the editor, so I can work on the other one separately. Would you mind reviewing this so we can merge it? Even if the iOS test fails because it gets frozen before finishing the test I think we should merge this one. What do you think? |
|
After a re-run the iOS test passed so we could merge this if it gets approved. |
fluiddot
approved these changes
Feb 7, 2023
adamziel
reviewed
Feb 7, 2023
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
|
Cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR brings changes from #47229 to the
experimentsnative variant.Why?
This change was breaking the editor.
How?
By bringing the latest changes from the
experimentsfile.Testing Instructions
CI checks should pass.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A