CustomSelectControl: update size prop options to new format in Storybook examples #47779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 433e58e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4103570189
|
tyxla
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While reviewing #47229 I noticed a warning in Storybook about an out-of-date format used to list options for the
sizeprops. This PR updates the code to the new format.Why?
Pre-requisite for the migration to Storybook v7 in the near future.
How?
Followed instructions from https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#deprecated-controloptions
Testing Instructions
npm run storybook:dev) and visitCustomSelectControl's examplessizeprops work as on production, showing three options to choose from via a radio interface:'small','default','__unstable-large'Screenshots or screencast
trunk