Move Link Control action buttons into lower settings area #47309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
the
[Feature] Link Editing
|
Size Change: +12 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
@richtabor Question: shoudl the tab order still be maintained? I.e. when you tab out of the search input the 1st tab stop is the I think that's pretty important to maintain from a UX POV but it does make the tab order not follow the visual order 😟 |
|
Flaky tests detected in 4b1ab14. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3972707240
|
10 tasks
Typically tab order should have a logical reading order, usually from left to right and top to bottom in LTR. Do you know of other UI where we've parted from that logic? Current visual for reference: CleanShot.2023-01-20.at.16.52.50.mp4 |
|
Yeh that's true and that's what's motivating my concern here. The issue I have is that a typical keyboard-based UX is:
With this change the new order would not allow that as the next tab stop after input would be the settings controls. That said power users can still simply hit ENTER immediately on the input to submit without having to tab to |
|
Per #47310 you can make the outline button into a text button. |
getdave
force-pushed
the
try/move-link-control-actions-into-settings-drawer
branch
from
8393a8c to
8954adf
Compare
|
@richtabor I reverted to the logical tab order. If folks don't like it then we can review in follow ups. As I mentioned earlier, we can still hit |
|
I've fixed both tests. Now awaiting a ✅ from someone 🙏 |
getdave
force-pushed
the
try/move-link-control-actions-into-settings-drawer
branch
from
dfc7642 to
4b1ab14
Compare
getdave
deleted the
try/move-link-control-actions-into-settings-drawer
branch
ntsekouras
pushed a commit
that referenced
this pull request
Feb 23, 2023
This reverts commit e605937.
ntsekouras
pushed a commit
that referenced
this pull request
Feb 24, 2023
* Revert "Move Link Control action buttons into lower area (#47309)" This reverts commit e605937. * Revert "Fix Link Control action button visuals (#47306)" This reverts commit 2499646. * Revert "Add clear Apply and Cancel buttons to Link Control (#46933)" This reverts commit 875628f. # Conflicts: # packages/block-editor/src/components/link-control/index.js
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements part of the design in this Issue by moving the action buttons into the lower "settings" area.
Part of #47310
Why?
It helps to clean up the amount of space utilised by the buttons. It implements the design.
How?
Moves buttons into the lower portion of the control.
Testing Instructions
Testing Instructions for Keyboard
As above but use a keyboard only. Ensure you can reach all of the controls within the link ui using the keyboard only.
Screenshots or screencast