TextareaControl: add new opt-in prop #46559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
added
[Type] Enhancement
|
Size Change: +10 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
mirka
approved these changes
Dec 15, 2022
packages/components/CHANGELOG.md
Outdated
| @@ -31,6 +31,7 @@ | |||
| - Lighten the border color on control components ([#46252](https://github.com/WordPress/gutenberg/pull/46252)). | |||
| - `Popover`: Prevent unnecessary paint when scrolling by using transform instead of top/left positionning ([#46187](https://github.com/WordPress/gutenberg/pull/46187)). | |||
| - `CircularOptionPicker`: Prevent unecessary paint on hover ([#46197](https://github.com/WordPress/gutenberg/pull/46197)). | |||
| - `Disabled`: Replace bottom margin overrides with `__nextHasNoMarginBottom` ([#46559](https://github.com/WordPress/gutenberg/pull/46559)). | |||
There was a problem hiding this comment.
We generally don't need to add changelogs for Storybook changes because they don't affect package consumers, and the public Storybook is not versioned.
There was a problem hiding this comment.
Good to know, thank you! I'll remove it from the PR before merging.
This reverts commit 95562a919a9e8c84b40e394c471a738a12b01c50.
brookewp
force-pushed
the
update/textareacontrol-margin
branch
from
ef9d449 to
709e31f
Compare
49 tasks
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding new opt-in prop
__nextHasNoMarginBottomto usages ofTextareaControlin the Gutenberg codebase.Why?
Part of this project: #38730
The tl;dr is
BaseControlhas amargin-bottomwhich makes it difficult to reuse and results in inconsistent use.How?
By adding the prop
__nextHasNoMarginBottom.Additional Notes
The prop needs to be added to the story for the
Disabledcomponent which is why this PR includes updates to that component for all threeSelectControl,TextControl, andTextareaControl. This is so future warnings of the margin-bottom deprecation won't show up in its default state.If this PR is merged first, #46448 will need to be rebased to include this change.
Testing Instructions
Test in the Block Editor (a Post)
PostExcerpt
Quick steps: the next three (cover, image, media & text blocks) all check for the image alt text areas. Continue for step-by-step or jump down to Site Editor steps after testing these three
CoverInspector
Image
MediaTextEdt
Test in the Site Editor
NavigationLinkEdit & NavigationSubmenuEdit
CustomCSSControl
Test in the Storybook
Disabled