Content lock: make filter hook namespace unique #46344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te of the equivalent in packages/block-editor/src/hooks/style.js The assumption is that namespaces should be unique. This is especially important since using `removeFilter` will remove them both otherwise.
ramonjd
added
[Type] Bug
ramonjd
requested review from
Mamaduka,
oandregal,
talldan and
jorgefilipecosta
|
Size Change: +7 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
talldan
added
the
Needs Dev Note
talldan
approved these changes
Dec 7, 2022
6 tasks
Thanks @talldan This comment seems to indicate that it wasn't, as it was part of the experimental package (?) https://make.wordpress.org/core/2022/10/11/content-locking-features-and-updates/#comment-43975 |
Withdraw that. I don't think it's in 6.1 after all. |
bph
added
has dev note
oandregal
reviewed
Dec 14, 2022
| @@ -168,6 +168,6 @@ export const withBlockControls = createHigherOrderComponent( | |||
|
|
|||
| addFilter( | |||
| 'editor.BlockEdit', | |||
| 'core/style/with-block-controls', | |||
| 'core/content-lock-ui/with-block-controls', | |||
There was a problem hiding this comment.
Oh, I missed this in my review. Thanks for taking care of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR is a follow up to #43037
I'm renaming the filter hook namespace from
'core/style/with-block-controls'to'core/content-lock-ui/with-block-controls'because the current value is a duplicate of the equivalent in packages/block-editor/src/hooks/style.jsThis is especially important since using
removeFilterwill remove them both otherwise, e.g.,Why?
The assumption is that namespaces should be unique. I could be wrong about this. If so, we should probably highlight the fact in the docs, which state that:
I'm happy to update the docs 😄
Testing Instructions