Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File block: Add spacing support #45107

Merged
merged 15 commits into from
Aug 4, 2023
Merged

File block: Add spacing support #45107

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
017af05
File block: Add spacing support
carolinan Oct 19, 2022
90d6346
Merge branch 'trunk' into update/file-spacing-support
carolinan Mar 6, 2023
cf727a8
Merge branch 'trunk' into update/file-spacing-support
carolinan Mar 14, 2023
ec8bbe6
tentatively add margin to classic.scss
carolinan Mar 14, 2023
6c59b40
Update classic.scss
carolinan Mar 14, 2023
39b239d
Merge branch 'trunk' into update/file-spacing-support
carolinan May 20, 2023
f4b6ecd
Merge branch 'trunk' into update/file-spacing-support
carolinan May 25, 2023
dcf14cd
Merge branch 'trunk' into update/file-spacing-support
carolinan Jun 14, 2023
460905d
Merge branch 'trunk' into update/file-spacing-support
carolinan Jun 26, 2023
fd1d087
Merge branch 'trunk' into update/file-spacing-support
carolinan Jun 30, 2023
137786d
Merge branch 'trunk' into update/file-spacing-support
carolinan Jul 2, 2023
9256bb8
Merge branch 'trunk' into update/file-spacing-support
carolinan Jul 11, 2023
3b55fc6
Merge branch 'trunk' into update/file-spacing-support
carolinan Jul 21, 2023
7035826
Merge branch 'trunk' into update/file-spacing-support
carolinan Jul 24, 2023
b8bb5c2
Remove experimental bottom margin
carolinan Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ Add a link to a downloadable file. ([Source](https://github.com/WordPress/gutenb

- **Name:** core/file
- **Category:** media
- **Supports:** align, anchor
- **Supports:** align, anchor, spacing (margin, padding)
- **Attributes:** displayPreview, downloadButtonText, fileId, fileName, href, id, previewHeight, showDownloadButton, textLinkHref, textLinkTarget

## Classic
Expand Down
13 changes: 12 additions & 1 deletion packages/block-library/src/file/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,18 @@
},
"supports": {
"anchor": true,
"align": true
"align": true,
"spacing": {
"margin": true,
"padding": true
},
"__experimentalStyle": {
"spacing": {
"margin": {
"bottom": "1.5em"
}
}
}
},
"viewScript": "file:./view.min.js",
"editorStyle": "wp-block-file-editor",
Expand Down
3 changes: 2 additions & 1 deletion packages/block-library/src/file/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.wp-block-file {
margin-bottom: 1.5em;
// This block has customizable padding, border-box makes that more predictable.
box-sizing: border-box;

&:not(.wp-element-button) {
font-size: 0.8em;
Expand Down