Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating curation document to include content lock ability #44908

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

annezazu
Copy link
Contributor

What?

Building off of the launch of this new functionality in 6.1, this updates the curation resource to include information about content lock ability: #43037 While there is currently documentation in place https://developer.wordpress.org/block-editor/reference-guides/block-api/block-templates/#locking this rounds out the current resources to provide practical examples, explain the benefits, and properly align it with other similar methods.

@richtabor thanks to your excellent article on the topic and your great feedback around naming, I'd love to have a review from you on this if you have time. I'm personally happy to fully roll with "content only editing" but wanted to keep it closer to what it was implemented as for now.

Building off of the launch of this new functionality in 6.1, this updates the curation resource to include information about content lock ability: #43037
@annezazu
Copy link
Contributor Author

Resolved all of the latest comments. Could I get additional reviews and, potentially, approvals? Of note, there's some discussion around implementing this on the dev note: https://make.wordpress.org/core/2022/10/11/content-locking-features-and-updates/

I might need to hold off on merging these doc updates depending on where things land.

@annezazu
Copy link
Contributor Author

@ryanwelcher could you review this by chance? The feature is going to be in for 6.1 and I'd like to ensure the docs are ready.

@justintadlock
Copy link
Contributor

Throwing another thought out there about "content-only" editing:

The phrasing is obviously weird because each of the other options refer to what they are locking. However, this particular option refers to what it allows.

From a development perspective, I see this more as a "design locking." What we're actually doing here is locking down the design tools.

It's a bit late to change "templateLock":"contentOnly" to "templateLock":"design" at this point, but it might be helpful to refer to this as a design-locking feature in communications with developers. I think it'd be easier to understand.

@annezazu
Copy link
Contributor Author

Hmm. Thank you for the insights @justintadlock -- is this a blocker in your mind? I'm wondering if we can proceed as is considering the dev note and a "close enough" feeling. If you feel really strongly, happy to update though as I do not :)

Curious what @richtabor thinks too.

@justintadlock
Copy link
Contributor

Hmm. Thank you for the insights @justintadlock -- is this a blocker in your mind? I'm wondering if we can proceed as is considering the dev note and a "close enough" feeling. If you feel really strongly, happy to update though as I do not :)

No strong feelings about it. Really, I was just making a note of this while the thought crossed my mind.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with the larger sentiment that the name still isn't ideal and I quite like the suggestion that @justintadlock posted. But I find this documentation update very valuable and should be merged now ahead of the 6.1 release to ensure we cover it in our documentation.

We can always follow up with additional improvements going forward.

@fabiankaegy fabiankaegy merged commit 74c0362 into trunk Oct 28, 2022
@fabiankaegy fabiankaegy deleted the annezazu-curation-update branch October 28, 2022 07:22
@github-actions github-actions bot added this to the Gutenberg 14.5 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants